From 437d0934869bba47c60cb5dff5b23e7f1eec3fa3 Mon Sep 17 00:00:00 2001
From: Jonathan Rosenbaum <bike@bikelover.org>
Date: Thu, 13 Jul 2023 03:06:58 -0400
Subject: [PATCH] Development improvements: Don't save temp containers, and
 recreate volumes by not making them external.

---
 docker-compose.build |  6 +++---
 docker-compose.yml   | 13 +++++++------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/docker-compose.build b/docker-compose.build
index 17cc92f..3bcdb3d 100755
--- a/docker-compose.build
+++ b/docker-compose.build
@@ -5,8 +5,8 @@
 # Also, you may need to remove and create the external volumes again for the steps
 # below to work correctly.
 docker compose up -d
-docker compose run bikebike rake db:setup
-docker compose run bikebike rake db:migrate 
-docker compose run bikebike rake assets:precompile
+docker compose run --rm bikebike rake db:setup
+docker compose run --rm bikebike rake db:migrate 
+docker compose run --rm bikebike rake assets:precompile
 docker compose down
 docker compose up -d 
diff --git a/docker-compose.yml b/docker-compose.yml
index 8d393e9..dc87cec 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -115,17 +115,18 @@ services:
         max-size: "10m"
         max-file: "3"
 
-# Create this volumes, docker volume create me
-# or comment our external
+# Currently set to false for all volumes for development,
+# but better strategy would be to keep or volumes true like
+# *_db
 volumes:
   bikebikebike_db:
-    external: true
+    external: false 
   bikebikebike:
-    external: true
+    external: false 
   bikebikebike_bundle:
-    external: true
+    external: false 
   bikebikebike_uploads:
-    external: true
+    external: false 
 
 # Remove this network if you don't use it
 networks: