From 072f303c65a3e6820edb6a4afb0c3d914d6afbc4 Mon Sep 17 00:00:00 2001
From: Ilya Konanykhin <ilya.konanykhin@gmail.com>
Date: Mon, 20 Mar 2017 21:41:07 +0600
Subject: [PATCH] BikeCsvImporter: refactor importer to output log messages to
 stdoud

---
 app/models/bike_csv_importer.rb | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/app/models/bike_csv_importer.rb b/app/models/bike_csv_importer.rb
index cf80a0f..2ffe75b 100644
--- a/app/models/bike_csv_importer.rb
+++ b/app/models/bike_csv_importer.rb
@@ -22,22 +22,28 @@ class BikeCsvImporter
   end
 
   def run(dry_run)
-    result = {imported: {}, skipped: {}}
+    imported_count, skipped_count = 0, 0
+
+    puts "Performing a #{dry_run ? 'DRY RUN' : 'LIVE RUN'} of import"
 
     fetch do |bike_hash|
        bike = new_bike bike_hash
        check_method = dry_run ? :valid? : :save
        if bike.try check_method
-         result[:imported][bike.shop_id] = bike.inspect
+         puts "Imported #{bike.shop_id}: #{bike}"
+         imported_count += 1
        else
-         result[:skipped][bike.try(:shop_id) || bike_hash.values.first] = bike.try(:errors).try(:messages)
+         puts "Skipped #{bike.try(:shop_id) || bike_hash.values.first}: #{bike.try(:errors).try(:full_messages).try :join, '; '}"
+         skipped_count += 1
        end
     end
 
-    result
+    puts "#{imported_count} bikes imported, #{skipped_count} bikes skipped, total of #{imported_count + skipped_count} rows in the CSV"
   end
 
   def analyze(fields = [])
+    puts "Analyzing CSV values frequency for #{fields.any? ? fields.join(', ') + ' field' : 'all fields'}"
+
     fields = fields.map &:downcase
     grouped = {}
     fetch do |bike_hash|
@@ -48,7 +54,14 @@ class BikeCsvImporter
         grouped[key][value]  += 1
       end
     end
-    grouped
+
+    grouped.each do |field, values|
+      puts "#{field}:"
+      values.each do |value, count|
+        puts "\t#{value.inspect}: #{count}"
+      end
+      puts "\tTotal of #{values.count} distinct values"
+    end
   end